Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, executor: add warning log for lock/unlock tables (#29301) #29440

Merged
merged 12 commits into from
Apr 12, 2022
Merged

ddl, executor: add warning log for lock/unlock tables (#29301) #29440

merged 12 commits into from
Apr 12, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 4, 2021 •
edited
Loading

cherry-pick #29301 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29440

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/29440:release-5.2-dcbfda914ad0

What problem does this PR solve?

Issue Number: close #28967

Problem Summary: Add warning log for lock tables and unlock tables when enable-table-lock flag not enabled.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@Defined2014 @ti-srebot
cherry pick pingcap#29301 to release-5.2
3a3b744 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 4, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 4, 2021
Merged
4 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.2-cherry-pick labels Nov 4, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 4, 2021
@ti-srebot
Copy link
Contributor Author

@Defined2014 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2021
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 11, 2022
@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9d8c745

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 11, 2022
@Defined2014
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4ccb812b5e948ca80e67bb47ea4eaecef4a695e8

@Defined2014
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@Defined2014
Copy link
Contributor

/merge

@Defined2014
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Defined2014
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 31b7654 into pingcap:release-5.2 Apr 12, 2022
@Defined2014 Defined2014 deleted the release-5.2-dcbfda914ad0 branch April 12, 2022 09:31
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.2.2, v5.2.4 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@morgo morgo morgo approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees

@Defined2014 Defined2014

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @Defined2014 @sre-bot @morgo @tangenta @VelocityLight @zhouqiang-cl